[tahoe-lafs-trac-stream] [tahoe-lafs] #1681: avoid using win32eventreactor, or suppress spurious warning from it if necessary (was: require pywin32 to get reliable disconnection detection, or else suppress Warning)

[tahoe-lafs]

#1681: avoid using win32eventreactor, or suppress spurious warning from it if
necessary
------------------------+-----------------------
     Reporter:  zooko   |      Owner:  somebody
         Type:  defect  |     Status:  new
     Priority:  major   |  Milestone:  undecided
    Component:  code    |    Version:  1.9.1
   Resolution:          |   Keywords:  warning
Launchpad Bug:          |
------------------------+-----------------------
Changes (by davidsarah):

 * keywords:   => warning
 * owner:  nobody => somebody
 * component:  unknown => code


Comment:

 We shouldn't be using win32eventreactor. If we end up using it, that's a
 bug, since it depends on pywin32 which we don't want to do [*]. The
 intention is to use the default select reactor on Windows. So why is that
 warning from win32eventreactor being emitted on !FreeStorm's XP
 buildslave, when there is no reference to it in Tahoe code? Is one of our
 dependencies sneakily referencing it, or is Twisted emitting the warning
 even when the reactor is not used (which would be a Twisted bug)?


 [*] I just noticed that [source:src/allmydata/test/common_util.py] still
 has a dependency on pywin32 (by importing {{{win32file}}} and
 {{{win32con}}}), although it falls back to something else if it is not
 present. We should probably fix that.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1681#comment:2>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage