[tahoe-lafs-trac-stream] [tahoe-lafs] #1333: 'private/' subdir of BASEDIR should be created during 'tahoe create-alias' and friends

[tahoe-lafs]

#1333: 'private/' subdir of BASEDIR should be created during 'tahoe create-alias'
and friends
--------------------------------+-----------------------
     Reporter:  warner          |      Owner:
         Type:  defect          |     Status:  new
     Priority:  minor           |  Milestone:  undecided
    Component:  code-nodeadmin  |    Version:  1.8.1
   Resolution:                  |   Keywords:  easy
Launchpad Bug:                  |
--------------------------------+-----------------------

Comment (by warner):

 discussing this on IRC just now, we agreed that both {{{create-alias}}}
 and {{{add-alias}}} are allowed to require the pre-existence of
 {{{NODEDIR}}} and {{{NODEDIR/node.url}}}, but both should
 {{{os.mkdir(NODEDIR/private)}}} when necessary.

 It'd be polite if both commands, when faced with a missing NODEDIR or
 NODEDIR/node.url, were to tell the user (in the error message) that they
 should create them, rather than throwing a weird exception that's hard to
 understand. But that's not strictly necessary to resolve this ticket.

 The main code changes will go into
 {{{src/allmydata/scripts/tahoe_add_alias.py}}}. The unit test should
 probably be added to the end of {{{CreateAlias.test_create}}} in
 source:src/allmydata/test/test_cli.py , and should clobber {{{private/}}}
 and then re-run {{{tahoe create-alias}}} and verify the results (by
 reading the alias file). It might be a good idea to test {{{add-alias}}}
 too, which is a bit easier (it doesn't need to talk to an actual node).

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1333#comment:2>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage