[tahoe-lafs-trac-stream] [tahoe-lafs] #951: uploads aren't cancelled by closing the web page
tahoe-lafs
trac at tahoe-lafs.org
Thu Jan 26 23:58:15 UTC 2012
#951: uploads aren't cancelled by closing the web page
-------------------------+-------------------------------------------------
Reporter: zooko | Owner: zooko
Type: defect | Status: assigned
Priority: major | Milestone: eventually
Component: code- | Version: 1.6.0
frontend-web | Keywords: usability upload large wui ophandle
Resolution: |
Launchpad Bug: |
-------------------------+-------------------------------------------------
Comment (by warner):
Zooko explained to me on IRC (and in #950) that it's the second case. I
think it'd be a bit gratuitous to terminate the upload just because they
disconnected, but it's predictable and understandable, so I can go along
with it.
This probably needs a {{{request.notifyFinish(cb)}}} on the web side, and
a bunch of new {{{.cancel}}} code on the Uploader side. Our current
interface just returns a Deferred, and doesn't have any sort of "upload-
in-progress" handle. Maybe the new "cancellable Deferred" code in recent
Twisteds could simplify this? like:
{{{
d = do_upload(body)
request.notifyFinish(d.cancel)
}}}
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/951#comment:7>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list