[tahoe-lafs-trac-stream] [tahoe-lafs] #1115: count-good-share-hosts is calculated incorrectly (post-repair says 10 hosts have good shares but there are only 4 hosts)

[tahoe-lafs]

#1115: count-good-share-hosts is calculated incorrectly (post-repair says 10 hosts
have good shares but there are only 4 hosts)
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  davidsarah
         Type:  defect   |     Status:  assigned
     Priority:  major    |  Milestone:  1.9.2
    Component:  code-    |    Version:  1.7.0
  frontend-web           |   Keywords:  usability easy repair servers-of-
   Resolution:           |  happiness upload review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 The definition of {{{needs-rebalancing}}} in
 [source:1.9.2/docs/frontends/webapi.rst] is:
 {{{
     needs-rebalancing: (bool) True if there are multiple shares on a
 single
                        storage server, indicating a reduction in
 reliability
                        that could be resolved by moving shares to new
                        servers.
 }}}
 but:
  * it is not true in general that multiple shares on a single storage
 server indicates a reduction in reliability. It depends whether those
 shares are not present on other servers.
  * the definition given does not correspond to what ''either''
 {{{checker.py}}} or {{{filenode.py}}} computes :-(

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1115#comment:28>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage