[tahoe-lafs-trac-stream] [tahoe-lafs] #1749: bug in mutable publish that could cause an IndexError when a writer is removed in Publish._connection_problem

[tahoe-lafs]

#1749: bug in mutable publish that could cause an IndexError when a writer is
removed in Publish._connection_problem
------------------------------+--------------------------------------------
     Reporter:  davidsarah    |      Owner:  kevan
         Type:  defect        |     Status:  new
     Priority:  critical      |  Milestone:  1.9.2
    Component:  code-mutable  |    Version:  1.9.1
   Resolution:                |   Keywords:  publish regression test-needed
Launchpad Bug:                |
------------------------------+--------------------------------------------
Changes (by davidsarah):

 * owner:  davidsarah => kevan
 * status:  assigned => new


Comment:

 I looked at changing it to use {{{DictOfSets}}}, but there are several
 instances of {{{self.writers.values()[0][0]}}}. Currently, that will
 always pick the first writer added for some arbitrary shnum. If I use
 {{{list(self.writers.values()[0])[0]}}}, that does pass tests, but it is
 using an arbitrary writer for an arbitrary shnum. Kevan (who wrote this
 code), is that change ok?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1749#comment:6>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage