[tahoe-lafs-trac-stream] [tahoe-lafs] #1669: ValueError (need more than 8 values to unpack) during mutable MDMF repair

[tahoe-lafs]

#1669: ValueError (need more than 8 values to unpack) during mutable MDMF repair
-------------------------+-------------------------------------------------
     Reporter:  vikarti  |      Owner:  zooko
         Type:  defect   |     Status:  assigned
     Priority:           |  Milestone:  1.9.2
  critical               |    Version:  1.9.1
    Component:  code-    |   Keywords:  mutable mdmf repair error
  mutable                |  regression preservation
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by zooko):

 Aha. I turned on code coverage display (see wiki:HowToWriteTests) and ran
 [source:1.9.2/src/allmydata/test/test_mutable.py?rev=5479#L2050
 test_mdmf_repairable_5shares]. This immediately shows that the code in
 question never gets exercised by that test. Aha! Because that test invokes
 {{{check}}} and then invokes {{{repair}}}. The code in question is in the
 implementation of {{{check_and_repair}}}.

 There, I made a new test that invokes {{{check_and_repair}}} and it
 exercises the bug. Victory!

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1669#comment:22>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage