[tahoe-lafs-trac-stream] [tahoe-lafs] #1566: if a stored share has a corrupt header, other shares held by that server for the file should still be accessible to clients

[tahoe-lafs]

#1566: if a stored share has a corrupt header, other shares held by that server
for the file should still be accessible to clients
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  warner
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  1.10.0
     Priority:  major    |    Version:  1.9.0b1
    Component:  code-    |   Keywords:  corruption preservation storage
  storage                |  design-review-needed zookos-opinion-wanted
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by kraeftig):

 I'm not going to re-assign this, as I don't feel completely confident that
 my review is sturdy enough to have properly understood this patch.  None
 the less, I feel like I have a good understanding of the impact the patch
 is trying to achieve and the abstract approach (thanks to the readability
 of the code).  I pretty much ignored syntax and looked only at the
 discourse that I could understand.

 It looks as though the ability to access the server's other shares, even
 if a corrupt header exists for one of those shares, is functional.  And
 one would be able to retrieve other files on that corrupted server, even
 with a return of corrupted headers.

 AFAIK, the application now identifies corrupt headers, circumvents them
 for the action, and then reports what headers were corrupt.

 Yay, my first review.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1566#comment:7>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage