[tahoe-lafs-trac-stream] [tahoe-lafs] #1688: ftpd returns 0 for all timestamps

[tahoe-lafs]

#1688: ftpd returns 0 for all timestamps
-------------------------------+-----------------------
     Reporter:  zooko          |      Owner:  lebek
         Type:  defect         |     Status:  new
     Priority:  minor          |  Milestone:  undecided
    Component:  code-frontend  |    Version:  1.9.1
   Resolution:                 |   Keywords:  ftpd
Launchpad Bug:                 |
-------------------------------+-----------------------

Comment (by lebek):

 Thanks for the review davidsarah.

 Replying to [comment:8 davidsarah]:
 > * Instead of the constant 626644800 in {{{expected_root}}}, use a class
 attribute, e.g. {{{self.FALL_OF_THE_BERLIN_WALL}}}.

 Done, also added a {{{self.TURN_OF_MILLENIUM}}} in order to differentiate
 the output in the case where both {{{mtime}}} and {{{linkmotime}}} are
 set.

 > * "{{{if name not in children: raise NoSuchChildError(name)}}}" in
 {{{_modifier}}} is not covered, and not needed (it's ok to let it raise a
 {{{KeyError}}} on {{{children[name]}}}).

 Agreed.

 > * The case where {{{"linkmotime"}}} is in the metadata is not tested. (I
 saw this by looking at the test coverage [*] and seeing that the relevant
 line "{{{value = metadata["tahoe"]["linkmotime"]}}}" of
 [source:src/allmydata/frontends/ftpd.py] was not run. Of course many other
 lines of {{{ftpd.py}}} are also not tested yet, but this is a line added
 by the fix.)

 Fixed.

 > * It is not tested that a file added via FTP (rather than by the
 internal Python API) is created with the right timestamp. This ticket can
 be closed without that test as long as it is documented on #512 that it is
 needed.

 I have added a note to #512.

 > * Add a comment above the relevant line in {{{expected_root}}} saying
 that the timestamp is expected to be 0 if no timestamp metadata is
 present.

 Done.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1688#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage