[tahoe-lafs-trac-stream] [tahoe-lafs] #680: Fix for mutable files with FTP

[tahoe-lafs]

#680: Fix for mutable files with FTP
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  davidsarah
  frozenfire             |     Status:  assigned
         Type:  defect   |  Milestone:  eventually
     Priority:  major    |    Version:  1.3.0
    Component:  code-    |   Keywords:  ftpd mutable reliability integrity
  frontend               |  test known-issue docs docs-needed news-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by davidsarah):

 * milestone:  undecided => eventually


Comment:

 Replying to [comment:25 davidsarah]:
 > Oh, the reason it fails is that {{{ReadFile}}} in
 [source:src/allmydata/frontends/ftpd.py] calls the {{{read}}} method of a
 filenode, which only exists for immutable filenodes.

 To fix that, do something like:
 {{{
     def send(self, consumer):
         d = self.node.get_best_readable_version()
         d.addCallback(lambda v: v.read(consumer))
         return d # when consumed
 }}}
 in {{{ReadFile}}}. But we'd also need tests for FTP (#512).

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/680#comment:26>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage