[tahoe-lafs-trac-stream] [tahoe-lafs] #1579: Patch to Add "Move" Functionality to Web Interface

[tahoe-lafs]

#1579: Patch to Add "Move" Functionality to Web Interface
-----------------------------------+---------------------
     Reporter:  marcusw            |      Owner:  amiller
         Type:  enhancement        |     Status:  new
     Priority:  normal             |  Milestone:  1.10.0
    Component:  code-frontend-web  |    Version:  1.9.1
   Resolution:                     |   Keywords:
Launchpad Bug:                     |
-----------------------------------+---------------------
Changes (by amiller):

 * keywords:  review-needed =>


Comment:

 I have reviewed this patch. It adds a 'move' operation to the Directory
 web view.

 - Both directories and files can be moved (from a mutable directory to a
 mutable directory).
 - By default, the semantic is similar to 'mv -f' in that a the destination
 name will be overwritten if it exists, although a '?replace=false' option
 is provided.
 - Attempts to move an object to a nonexistent or not-writeable directory
 will return 410 Gone.
 - Destination directories can be indicated by URI or by pathname
 - Slashes in the destination name aren't permitted, though they're
 accepted for source

 The move operation (dirnode.py) is a symlink followed a copy followed (on
 success) by an unlink, so the only possible race condition would result in
 two instances of the file. This behavior seems safe and isn't at all
 specific to the web interface anyway.

 Straightforward tests are provided for all of the failure cases (except
 the interrupted-move described above, which is OK).

 Minor note: a meme was applied incorrectly for the name of a nonexistent
 directory - 'notchucktesta' should be 'nopechecktesta'

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1579#comment:13>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage