[tahoe-lafs-trac-stream] [tahoe-lafs] #1240: remove ResponseCache in favour of MDMFSlotReadProxy's cache

[tahoe-lafs]

#1240: remove ResponseCache in favour of MDMFSlotReadProxy's cache
------------------------------+---------------------------
     Reporter:  davidsarah    |      Owner:  amiller
         Type:  defect        |     Status:  new
     Priority:  major         |  Milestone:  1.10.0
    Component:  code-mutable  |    Version:  1.8.0
   Resolution:                |   Keywords:  mutable cache
Launchpad Bug:                |
------------------------------+---------------------------
Changes (by lebek):

 * keywords:  review-needed mutable cache => mutable cache
 * owner:  lebek => amiller


Comment:

 Thanks amiller, I just reviewed this - a net negative lines of code patch,
 which also increases cache hits, very nice.

 Everything looks good to me, just two points:

  * {{{test_deepcheck_cachemisses}}} is functionally identical to
 {{{test_deepcheck}}}. The print of the {{{slot_readv}}} call count should
 to be removed and replaced with unittest assertions that verify the cache
 is accessed when it should be (I think you mention this above)
  * in {{{retreive.py}}} you import {{{allmydata.util.spans}}}, but the
 module is never used

 That's all.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1240#comment:13>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage