[tahoe-lafs-trac-stream] [tahoe-lafs] #1115: add servers-of-happiness to reports (post-repair says 10 hosts have good shares but there are only 4 hosts)

[tahoe-lafs]

#1115: add servers-of-happiness to reports (post-repair says 10 hosts have good
shares but there are only 4 hosts)
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  warner
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:  1.9.2
    Component:  code-    |    Version:  1.7.0
  frontend-web           |   Keywords:  usability easy repair servers-of-
   Resolution:           |  happiness upload
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by warner):

 * keywords:  usability easy repair servers-of-happiness upload review-
     needed => usability easy repair servers-of-happiness upload
 * owner:  davidsarah => warner
 * status:  assigned => new


Comment:

 Yeah, that describes what I had in mind for count-good-share-hosts, but
 I agree that it probably isn't as meaningful as I'd originally thought.
 The sharemap described in comment:6 is a great example, although I think
 it'd be awfully hard to get into this situation (it would take some
 serious contortions to get an uploader+repairer to leave shares in that
 state). count-good-share-hosts probably covered the situations I was
 able to imagine happening after a typical upload process, but if there's
 a better "what needs to happen to make your file healthier" value, I'm
 happy to emphasize that instead.

 Anyways, I reviewed the patch and it looks good. I added a few cosmetic
 fixes (whitespace, name of the test file), and will land it in a minute.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1115#comment:18>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage