[tahoe-lafs-trac-stream] [tahoe-lafs] #1739: servers-responding list is wrong

[tahoe-lafs]

#1739: servers-responding list is wrong
------------------------+--------------------
     Reporter:  warner  |      Owner:  warner
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  1.9.2
    Component:  code    |    Version:  1.9.1
   Resolution:          |   Keywords:  repair
Launchpad Bug:          |
------------------------+--------------------
Changes (by davidsarah):

 * keywords:  review-needed => repair
 * owner:  zooko => warner
 * status:  assigned => new
 * priority:  minor => normal


Comment:

 +1 on removing !DictOfSets.union; I was looking at using !DictOfSets for
 something and also found that method confusing. I confirmed that the
 patches remove all uses.

 Would {{{d['servers-responding'] = sorted(list(servers_responding))}}} be
 better, for determinism? (I know the previous code also wasn't
 deterministic here.)

 I think the overloading of {{{.broken}}} as an int or boolean will not
 work as intended for the boolean case, because:
 {{{
 $ python
 Python 2.6.6 (r266:84292, Sep 15 2010, 16:22:56)
 [GCC 4.4.5] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 >>> broken = True
 >>> isinstance(broken, int)
 True
 >>> broken -= 1
 >>> broken
 0
 }}}

 Otherwise looks good.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1739#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage