[tahoe-lafs-trac-stream] [tahoe-lafs] #1729: memory leak in allmydata.test.test_web

[tahoe-lafs]

#1729: memory leak in allmydata.test.test_web
------------------------+-------------------------------------
     Reporter:  zooko   |      Owner:  Brian Warner <warner@…>
         Type:  defect  |     Status:  closed
     Priority:  normal  |  Milestone:  undecided
    Component:  code    |    Version:  1.9.1
   Resolution:  fixed   |   Keywords:  test memory
Launchpad Bug:          |
------------------------+-------------------------------------
Changes (by Brian Warner <warner@…>):

 * owner:   => Brian Warner <warner@…>
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:5543/trunk]:
 {{{
 #!CommitTicketReference repository="trunk" revision="5543"
 test_web.py: fix memory leak when run with --until-failure

 The Fake*Node classes in test/common.py were accumulating share data in
 a class-level dictionary, which persisted from one test run to the next.
 As a result, running test_web.py over and over (with trial's
 --until-failure feature) made this dictionary grow without bound,
 eventually running out of memory.

 This fix moves that dictionary into the FakeClient built fresh for each
 test, so it doesn't build up. It does the same thing for "file_types",
 which was much smaller but still lived at the class level.

 Closes #1729
 }}}

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1729#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage