[tahoe-lafs-trac-stream] [tahoe-lafs] #1740: new zope.interface deprecation warning about "implements()"

[tahoe-lafs]

#1740: new zope.interface deprecation warning about "implements()"
-------------------------+-------------------------------------------------
     Reporter:  warner   |      Owner:  davidsarah
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:  1.9.2
    Component:  code     |    Version:  1.9.1
   Resolution:           |   Keywords:  zope.interface deprecation warning
Launchpad Bug:           |  error
-------------------------+-------------------------------------------------
Changes (by warner):

 * keywords:  zope.interface deprecation warning error review-needed =>
     zope.interface deprecation warning error
 * owner:  warner => davidsarah


Comment:

 Looks ok to me. I'd maybe add a note to make it more obvious that the
 {{{warnings.filters.pop()}}} are supposed to match the
 {{{warnings.filterwarnings()}}} calls earlier, and that
 {{{global_deprecation_messages}}} are left in place because the filter
 list acts like a stack (in particular, if {{{deprecation_messages}}} or
 {{{global_deprecation_messages}}} were a set instead of a list, it
 wouldn't work). I might add a comment to that effect myself after it
 lands.

 In the long run, we should pay attention to what our fellow zope
 .interface-users are doing. If this decorator thing has been around long
 enough, and it doesn't hurt us otherwise, it might be nice to follow their
 advice and update the way we use {{{implements}}}.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1740#comment:4>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage