[tahoe-lafs-trac-stream] [tahoe-lafs] #1749: bug in mutable publish that could cause an IndexError when a writer is removed in Publish._connection_problem

[tahoe-lafs]

#1749: bug in mutable publish that could cause an IndexError when a writer is
removed in Publish._connection_problem
------------------------------+--------------------------------------------
     Reporter:  davidsarah    |      Owner:  zooko
         Type:  defect        |     Status:  new
     Priority:  critical      |  Milestone:  1.9.2
    Component:  code-mutable  |    Version:  1.9.1
   Resolution:                |   Keywords:  publish regression test-needed
Launchpad Bug:                |
------------------------------+--------------------------------------------

Comment (by warner):

 Seriously though, yes, {{{DictOfSets}}} was made for this. It deletes the
 key from the dict when the last value is removed. I skimmed through
 publish.py: the only place that populates {{{self.writers}}} does so from
 an unordered set, so {{{self.writers}}} does not need to retain order, so
 {{{DictOfSets}}} is sufficient, and {{{DictOfLists}}} is not necessary.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1749#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage