[tahoe-lafs-trac-stream] [tahoe-lafs] #1240: remove ResponseCache in favour of MDMFSlotReadProxy's cache

[tahoe-lafs]

#1240: remove ResponseCache in favour of MDMFSlotReadProxy's cache
------------------------------+---------------------------------------
     Reporter:  davidsarah    |      Owner:  amiller
         Type:  defect        |     Status:  new
     Priority:  major         |  Milestone:  1.10.0
    Component:  code-mutable  |    Version:  1.8.0
   Resolution:                |   Keywords:  mutable cache test-needed
Launchpad Bug:                |
------------------------------+---------------------------------------
Changes (by amiller):

 * keywords:  mutable cache review-needed => mutable cache test-needed
 * owner:   => amiller


Comment:

 Kicking it back to myself, since adding 'corrupt_early=True' does in fact
 change the semantic of the test (this is the reason there's both a
 'corrupt' and a 'corrupt_late' version of each corruption test).

 The first two tests were fixed by increasing the length of the content so
 that a second server fetch is necessary. However the third test involves
 corruption of the block hash tree (BHT), which is typically small and
 doesn't exceed the first cache fill. Since there's no guarantee that the
 BHT will fit in the first cache fill, it's wrong to remove this test.

 Ways to proceed:
     1. Introduce a way to disable the cache for a particular test. This
 would also require a unit test to assert whether the cache is used or not.
     2. Figure out how to force the block-hash-tree to be huge, so that it
 exceeds the initial cache fill on its own?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1240#comment:24>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage