[tahoe-lafs-trac-stream] [tahoe-lafs] #1852: test suite: find a way to prevent unclean reactor errors causing subsequent test failures

[tahoe-lafs]

#1852: test suite: find a way to prevent unclean reactor errors causing subsequent
test failures
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  davidsarah
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  undecided
     Priority:  normal   |    Version:  1.9.2
    Component:  code     |   Keywords:  test twisted-trial unclean reactor
   Resolution:           |  timeout hang
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 Ah, I did not know about the {{{reactor.getDelayedCalls}}} method used by
 {{{clean_pending}}}. I think {{{clean_pending}}} does not quite do the
 right thing, though:
  * I want the delay, because that's more likely to avoid problems with
 subsequent tests. Cancelling the delayed calls might still leave other
 reactor resources unclean.
  * I think {{{clean_pending}}} will cancel the Deferred that implements
 the test timeout, or any others that are internal to Twisted Trial. (There
 weren't any others when I tested, but that's an implementation detail.)

 I'll see whether {{{reactor.getDelatedCalls}}} can be used to replace the
 use of internal attributes of {{{reactor}}} in {{{WaitForDelayedCalls}}}.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1852#comment:7>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage