[tahoe-lafs-trac-stream] [tahoe-lafs] #1735: the banner on the Welcome page saying that a helper is not configured should not be red

[tahoe-lafs]

#1735: the banner on the Welcome page saying that a helper is not configured
should not be red
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  kick
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  1.10.0
     Priority:  normal   |    Version:  1.9.1
    Component:  code-    |   Keywords:  welcome wui aesthetics usability
  frontend-web           |  easy
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by warner):

 * keywords:  welcome wui aesthetics usability easy review-needed => welcome
     wui aesthetics usability easy


Comment:

 Kick: looks good! Some ideas we had:

 * could you change the "not-configured" color to plain white (to
   match the background), instead of light green? We figured it'd be
   good to be as neutral as possible for something which isn't
   configured.
 * I'd use "unconfigured" instead of "disabled", in general (since
   "disabled" kind of implies that using a Helper is the normal
   state, whereas actually Helpers are somewhat unusual).
 * I'd recommend leaving out the "no, enable for quicker uploads"
   line: the actual benefit of the helper will depend upon having a
   helper that's closer to the servers than you are, and on using
   encoding parameters that help (in some cases the helper will be
   slower than a direct upload). Simply saying "unconfigured" would
   be enough.
 * the indentation in {{{data_connected_to_helper_description()}}}
   looks wrong.. maybe it's using tabs? All python code should use
   four-space indents.
 * we should add a test for this. The test should local the Welcome
   page three times: once with no helper configured, a second time
   with the helper furl configured but no connection, and a third
   time with the helper connected. {{{test_web.py}}} is the place to
   add it, in the existing {{{Web.test_welcome}}} case (around line
   526). The test will need a little more support in
   {{{FakeUploader}}} (line 102), to return e.g.
   {{{self.helper_furl}}} and {{{self.helper_connected}}} instead of
   always returning {{{(None, False)}}}. Then the test case can
   reach into {{{self.s.uploader}}} and set
   {{{helper_furl}}}/{{{helper_connected}}} between the different
   cases. You'll need to follow the pattern in {{{test_welcome()}}}:
   {{{self.GET()}}} returns a Deferred, so you'll add a helper
   function (that scans the HTML output for "Connected to helper?:
   unconfigured", etc) through a {{{d.addCallback}}}.

 Grab any of us (warner, zooko, davidsarah) on IRC if you need a
 hand with the test.

 thanks!
  -Brian

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1735#comment:4>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage