[tahoe-lafs-trac-stream] [tahoe-lafs] #1171: shnums: "e, r, r, o, r"

[tahoe-lafs]

#1171: shnums: "e,r,r,o,r"
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  warner
         Type:  defect   |     Status:  closed
     Priority:  major    |  Milestone:  1.10.0
    Component:  code-    |    Version:  1.8β
  frontend-web           |   Keywords:  download immutable unfinished-
   Resolution:  fixed    |  business
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by warner):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 It looks like the changes I had in mind have been applied already.
 Specifically, source:src/allmydata/immutable/downloader/status.py#L42
 {{{DYHBEvent}}} has a distinct {{{error()}}} method, and
 source:src/allmydata/immutable/downloader/finder.py calls exactly one of
 {{{finished()}}} or {{{error()}}}. So {{{shnums}}} should only ever be a
 list of share numbers (keys of the dict-of-buckets returned by a
 successful DYHB call).

 So I'm closing this one.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1171#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage