[tahoe-lafs-trac-stream] [tahoe-lafs] #1807: cleanup: HUMAN_RE regexes in uri.py are never used

[tahoe-lafs]

#1807: cleanup: HUMAN_RE regexes in uri.py are never used
----------------------------+---------------------------------------
     Reporter:  davidsarah  |      Owner:  warner
         Type:  defect      |     Status:  new
     Priority:  minor       |  Milestone:  1.11.0
    Component:  code        |    Version:  1.9.2
   Resolution:              |   Keywords:  cleanup url review-needed
Launchpad Bug:              |
----------------------------+---------------------------------------

Comment (by davidsarah):

 Replying to [comment:2 zooko]:
 > Why not use the "human encoding" parser of URLs instead of removing it
 and making the normal parsing of URLs more like it?

 Because:
  - there's no ticket proposing to allow an {{{http://...}}} prefix for
 Tahoe URIs, and I don't think we want that.
  - the human encoding parsers don't implement #884 or #885. They partially
 implement #942, but inconsistently, for example most of the "{{{:}}}"
 characters can be replaced by "{{{%3A}}}" (matched case-sensitively, which
 is wrong), but the one before an MDMF extension field cannot. This is
 because #942 is implemented in a suboptimal way: we should be %-unencoding
 the whole Tahoe URI rather than treating "{{{:}}}" as a special case.
  - making this change has very little regression risk because it is only
 dead code that is being removed.
  - most of the work of implementing #942, #884, and #885 is in adding and
 repairing tests, the non-test code changes are straightforward. So not
 much effort is actually saved by reusing the human encoding code.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1807#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage