[tahoe-lafs-trac-stream] [tahoe-lafs] #666: Accounting: limit storage space used by different parties

[tahoe-lafs]

#666: Accounting: limit storage space used by different parties
------------------------------+------------------------
     Reporter:  warner        |      Owner:
         Type:  task          |     Status:  new
     Priority:  major         |  Milestone:  2.0.0
    Component:  code-storage  |    Version:  1.3.0
   Resolution:                |   Keywords:  accounting
Launchpad Bug:                |
------------------------------+------------------------

Comment (by davidsarah):

 Replying to [comment:8 zooko]:
 > It would be simpler, and probably just as efficient, to call sqlite's
 {{{self._db.commit()}}} method every time instead of maintaining a dirty
 flag in a member variable and calling {{{self._db.commit()}}} only when
 that flag is True. Maintaining that flag gives us opportunities to write
 bugs, and also it adds load to reviewers -- I don't understand why there
 is an {{{always}}} option and why it is used from the history writer. If
 we always just call {{{self._db.commit()}}} then I as a reviewer wouldn't
 have to wonder about that and would have more cognitive bandwidth leftover
 to look for other issues.

 This was in Brian's code, to allow reducing the number of DB transactions,
 but I agree it is possibly a premature optimization. I'll think about
 removing it.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/666#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage