[tahoe-lafs-trac-stream] [tahoe-lafs] #1525: SFTP: handle download failures correctly; remove use of IFinishableConsumer

[tahoe-lafs]

#1525: SFTP: handle download failures correctly; remove use of IFinishableConsumer
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  warner
  davidsarah             |     Status:  closed
         Type:  defect   |  Milestone:  1.10.0
     Priority:           |    Version:  1.9.0a1
  critical               |   Keywords:  sftp hang error streaming
    Component:  code-    |  performance blocker
  frontend               |
   Resolution:  fixed    |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by warner):

 * keywords:  sftp hang error streaming performance blocker review-needed =>
     sftp hang error streaming performance blocker
 * status:  new => closed
 * resolution:   => fixed


Comment:

 I spent a couple of hours on the plane studying the SFTP code. Wow, it's
 complex. It may need to be that complex, but it sure was hard to get my
 head around the control flows. I've got a list of code-cleanup
 suggestions, but I suspect most of them were applicable to the pre-#1525
 code as well, so don't really qualify as review for this ticket. I think
 I'll open a separate ticket to discuss them. If Daira's manual and
 automated testing shows these changes to have worked correctly, I'm +1 on
 them too.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1525#comment:18>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage