[tahoe-lafs-trac-stream] [tahoe-lafs] #2052: Automate testing of merge requests to streamline review.

[tahoe-lafs]

#2052: Automate testing of merge requests to streamline review.
--------------------------+-----------------------------------------
     Reporter:  nejucomo  |      Owner:  daira
         Type:  defect    |     Status:  new
     Priority:  normal    |  Milestone:  undecided
    Component:  unknown   |    Version:  1.10.0
   Resolution:            |   Keywords:  dev-infrastructure buildbot
Launchpad Bug:            |
--------------------------+-----------------------------------------

Comment (by zooko):

 Well… how about this:

 * the buildbot should run code only from a whitelist of repositories. This
 is already in place: https://github.com/markberger/buildbot-config-
 tahoe/blob/master/tahoe/git/master.cfg#L43
 * a trusted Tahoe-LAFS volunteer is expected to manually commit any
 patches to some repo in the whitelist in order for buildbot to test that
 patch; This implies that we extend the whitelist to include at least one
 repo that every trusted Tahoe-LAFS volunteer can push into
 * the volunteer is expected to perform some sort of minimal gating of
 these patches, such as that they glanced at the patch for 1 second, or
 that the patch came from a source that they know, before pushing it into
 such a whitelisted repo
 * the volunteer is ''not'' expected to inspect the patch critically in
 search of vulnerabilities or trojan code before so pushing it
 * we have some kind of append-only log of which patches got built and the
 provenance of where those patches came from (maybe git+github will give us
 this for free?)

 markberger: what do you think so far?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2052#comment:6>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage