[tahoe-lafs-trac-stream] [tahoe-lafs] #1396: writing an incident flogfile (via foolscap 0.6.0/1) tries to use characters not valid in a Windows filename (':')

[tahoe-lafs]

#1396: writing an incident flogfile (via foolscap 0.6.0/1) tries to use characters
not valid in a Windows filename (':')
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  somebody
  davidsarah             |     Status:  closed
         Type:  defect   |  Milestone:  1.10.0
     Priority:  major    |    Version:  1.8.2
    Component:  code     |   Keywords:  windows error incident logging
   Resolution:  fixed    |  foolscap regression
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by daira):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  soon (release n/a) => 1.10.0


Old description:

> While reporting the incident in #1395 on a Windows platform, the
> following error occurred:
> {{{
> [Failure instance: Traceback: <type 'exceptions.IOError'>:
> [Errno 22] invalid mode ('wb') or filename:
> u'C:\\tahoeclient\\logs\\incidents\\incident-2011-05-05--18:33:34Z-
> w2qn32q.flog'
> }}}
>
> The problem (or at least one problem) is that '{{{:}}}' is not valid in a
> Windows filename. [http://msdn.microsoft.com/en-
> us/library/aa365247%28v=vs.85%29.aspx This MSDN article] documents the
> Windows filename validity rules.
>
> Presumably we don't have any test of writing an incident flogfile. ~~This
> may mean that incident reporting has always been broken on Windows
> (unless the flogfile naming changed?)~~ A change to flogfile naming in
> foolscap 0.6.0 apparently caused this bug.

New description:

 While reporting the incident in #1395 on a Windows platform, the following
 error occurred:
 {{{
 [Failure instance: Traceback: <type 'exceptions.IOError'>:
 [Errno 22] invalid mode ('wb') or filename:
 u'C:\\tahoeclient\\logs\\incidents\\incident-2011-05-05--18:33:34Z-
 w2qn32q.flog'
 }}}

 The problem (or at least one problem) is that '{{{:}}}' is not valid in a
 Windows filename. [http://msdn.microsoft.com/en-
 us/library/aa365247%28v=vs.85%29.aspx This MSDN article] documents the
 Windows filename validity rules.

 Presumably we don't have any test of writing an incident flogfile. ~~This
 may mean that incident reporting has always been broken on Windows (unless
 the flogfile naming changed?)~~ A change to flogfile naming in foolscap
 0.6.0 apparently caused this bug.

--

Comment:

 trunk requires foolscap >= 0.6.3 (since
 [69bd49fc57bf9e6f851c8f68458d6f518d2c8c2e/trunk], which was before the
 1.10 release), so this is fixed.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1396#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage