[tahoe-lafs-trac-stream] [tahoe-lafs] #1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS

[tahoe-lafs]

#1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS
-------------------------------+---------------------------
     Reporter:  davidsarah     |      Owner:  daira
         Type:  defect         |     Status:  new
     Priority:  minor          |  Milestone:  1.11.0
    Component:  code-encoding  |    Version:  1.9.2
   Resolution:                 |   Keywords:  review-needed
Launchpad Bug:                 |
-------------------------------+---------------------------
Changes (by zooko):

 * status:  assigned => new


Comment:

 I just reviewed this, too, comparing https://github.com/basu123/tahoe-
 lafs/commit/51dcecd01a730f588ce439a013d19c67f8f131b9#commitcomment-4763253
 to https://github.com/daira/tahoe-
 lafs/commit/ab9216e5728083a671060ba12c98f56638f08517 . I had one question
 about a way that these two patches differ:

 https://github.com/basu123/tahoe-
 lafs/commit/51dcecd01a730f588ce439a013d19c67f8f131b9#commitcomment-4763253

 Also, wiki:CodingStandards says "Prepend a leading underscore to private
 names.", so the way https://github.com/daira/tahoe-
 lafs/commit/ab9216e5728083a671060ba12c98f56638f08517 did that is
 preferred.

 Otherwise, I don't see any problem with either of these two patches and
 either one can be merged to trunk in my opinion.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1847#comment:23>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage