[tahoe-lafs-trac-stream] [tahoe-lafs] #1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS

[tahoe-lafs]

#1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS
-------------------------------+----------------------
     Reporter:  davidsarah     |      Owner:  daira
         Type:  defect         |     Status:  new
     Priority:  minor          |  Milestone:  1.11.0
    Component:  code-encoding  |    Version:  1.9.2
   Resolution:                 |   Keywords:  reviewed
Launchpad Bug:                 |
-------------------------------+----------------------

Comment (by daira):

 Replying to [comment:23 zooko]:
 > Also, wiki:CodingStandards says "Prepend a leading underscore to private
 names.", so the way https://github.com/daira/tahoe-
 lafs/commit/ab9216e5728083a671060ba12c98f56638f08517 did that is
 preferred.

 I disagree, because these attributes aren't private. (I count attributes
 as non-private if they are accessed directly from anywhere outsiede the
 class, including tests.) The patch looks fine to me in this respect; I had
 originally planned to add a method to set parameters, but I think it's not
 needed.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1847#comment:26>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage