[tahoe-lafs-trac-stream] [tahoe-lafs] #2128: comments in tahoe.cfg cause introducers to appear down

[tahoe-lafs]

#2128: comments in tahoe.cfg cause introducers to appear down
-------------------------+--------------------------------------------
     Reporter:  amiller  |      Owner:  daira
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  undecided
    Component:  unknown  |    Version:  1.10.0
   Resolution:           |   Keywords:  review-needed usability config
Launchpad Bug:           |
-------------------------+--------------------------------------------

Comment (by daira):

 Replying to [comment:17 zooko]:
 > Replying to [comment:16 daira]:
 > > I continue to think we should not treat furls as a special case
 (comment:7).
 >
 > So what if [https://github.com/amiller/tahoe-
 lafs/commit/47694c89d0e40ca869f74a53fee9703349dca474 Andrew's patch] were
 applied to all values from the config. Would that be better?

 Yes, the approach in comment:8 seems like a reasonable way of doing that.
 (It only checks values that are used, rather than all lines of the file,
 but that should be fine.)

 > Also, daira, what should we do about a string like "{{{test\\#test}}}"
 in a value from the config?

 That string doesn't contain an escaped {{{#}}} (only an escaped {{{\}}}),
 so it contains a {{{#}}}-comment and should be rejected. I don't
 understand the regexp in comment:15 though. (BTW, I suggest using raw
 {{{r"..."}}} strings for regexps, to avoid the extra level of \-escaping.
 Triple-quoted strings aren't necessary.)

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2128#comment:18>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage