[tahoe-lafs-trac-stream] [tahoe-lafs] #1159: stop using .tac files: make it possible to change appname, Python package-directory name, perhaps other names

[tahoe-lafs]

#1159: stop using .tac files: make it possible to change appname, Python package-
directory name, perhaps other names
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  davidsarah
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  1.10.0
     Priority:  major    |    Version:  1.8β
    Component:  code-    |   Keywords:  test-needed backward-compatibility
  nodeadmin              |  forward-compatibility appname tac needs-spawn
   Resolution:           |  packaging setuptools review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 {{{
 twistd_args.extend(config.twistd_args)
 twistd_args.append("XYZ") # point at our NodeStartingPlugin
 }}}
 Could an argument to {{{tahoe}}} that does not start with {{{"--"}}} be
 confused by {{{twistd}}} for the command name?

 If I try {{{tahoe start ~/.tahoe foo}}} (which should be an error), I get
 a twistd options listing followed by a !TypeError traceback, which appears
 to be due to a bug at {{{startstop_node.py}}} line 114. This change fixes
 the bug, and snips some implementation details about twistd from the end
 of the options listing:
 {{{
 -        print >>err, "tahoe start: %s" % (config.subCommand, ue)
 -        print >>err, twistd_config
 ---
 +        print >>err, str(twistd_config).partition("\n\n")[0]
 +        print >>err
 +        print >>err, "tahoe start: %s\n" % (ue,)
 }}}

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1159#comment:37>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage