[tahoe-lafs-trac-stream] [tahoe-lafs] #1746: write test for anti-Ubuntu-crash-reporter exception-catching code

[tahoe-lafs]

#1746: write test for anti-Ubuntu-crash-reporter exception-catching code
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zooko
  ChosenOne              |     Status:  new
         Type:  defect   |  Milestone:  1.10.0
     Priority:  normal   |    Version:  1.9.1
    Component:  code-    |   Keywords:  cli ubuntu apport usability error
  frontend-cli           |  reviewed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by amiller):

 * keywords:  cli ubuntu apport usability error review-needed => cli ubuntu
     apport usability error reviewed


Comment:

 I've reviewed this patch and its test. The patch catches all exceptions in
 the CLI by having a try/catch around the 'run' function for all CLI
 commands. The test correctly distinguishes between when this exception is
 caught rather than propagated. I haven't directly checked that this solves
 the ubuntu app reporting problem, since I don't know how to build the
 ubuntu version. But ChosenOne's analysis about how catching the exception
 solves the problem makes sense.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1746#comment:18>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage