[tahoe-lafs-trac-stream] [tahoe-lafs] #1280: deal with fragile, but disposable, bucket state files

[tahoe-lafs]

#1280: deal with fragile, but disposable, bucket state files
--------------------------------+--------------------------------
     Reporter:  francois        |      Owner:  daira
         Type:  defect          |     Status:  new
     Priority:  normal          |  Milestone:  1.11.0
    Component:  code-nodeadmin  |    Version:  1.8.1
   Resolution:                  |   Keywords:  pickle reliability
Launchpad Bug:                  |
--------------------------------+--------------------------------
Changes (by zooko):

 * owner:  zooko => daira
 * status:  reopened => new


Comment:

 Replying to [comment:12 daira]:
 > I suspect that changeset
 [changeset:3cb99364e6a83d0064d2838a0c470278903e19ac/trunk 3cb99364]
 effectively fixed this ticket. (It doesn't delete a corrupted state file,
 but it does use default values, and the corrupted file will be overwritten
 on the next crawler pass.) Please close this ticket as fixed in milestone
 1.9.2 if you agree.

 I agree, so I'll close this ticket, but there's something that I don't
 like about [changeset:3cb99364e6a83d0064d2838a0c470278903e19ac/trunk
 3cb99364], which is that it catches arbitrary {{{Exception}}} instead of a
 set of exceptions that we think it should handle. Catching of general
 {{{Exception}}} has caused problems in the past, such as when the
 exception being caught is due to a shallow bug in the the code (like an
 {{{AttributeError}}}, or a out-of-memory exception, etc. How about if we
 change it from catching {{{Exception}}} to catching {{{(EnvironmentError,
 EOFError, KeyError)}}}?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1280#comment:13>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage