[tahoe-lafs-trac-stream] [tahoe-lafs] #2023: regression coincident with iputil fixes, on FreeBSD and Slackware

[tahoe-lafs]

#2023: regression coincident with iputil fixes, on FreeBSD and Slackware
------------------------------+-------------------------------------------
     Reporter:  zooko         |      Owner:  daira
         Type:  defect        |     Status:  new
     Priority:  normal        |  Milestone:  1.11.0
    Component:  code-network  |    Version:  1.10.0
   Resolution:                |   Keywords:  regression portability iputil
Launchpad Bug:                |
------------------------------+-------------------------------------------
Description changed by zooko:

Old description:

> Our buildbot shows that when this batch of patches went in:
>
> [f77ec470d75f4b8fb81b1abca4ee3b73f1ad8b22],
> [8e31d66cd0b0821ccaa2c7c259e7d6f262ad4738],
> [6a445d73bc5253ec4ae0dec70af02e33bc869cf6],
> [d85a75d7f689cb55ecddb319dc2057f38e4db87a]
>
> Then the FreeBSD and Slackware builders went from green to red. See this
> historical waterfall view:
>
> [//buildbot-tahoe-
> lafs/waterfall?builder=Markus+slackware64+current&builder=Randy+FreeBSD-
> amd64&reload=none&last_time=1372000000 https://tahoe-lafs.org/buildbot-
> tahoe-lafs/waterfall?builder=Markus+slackware64+current&builder=Randy
> +FreeBSD-amd64&reload=none&last_time=1372000000]
>
> Out of those four patches, I don't believe that
> [d85a75d7f689cb55ecddb319dc2057f38e4db87a] is relevant, but the other
> three could be. Especially note that the error message on the FreeBSD and
> Slackware builders is "twisted.trial.unittest.FailTest: Errors snooped,
> terminating early", and that [f77ec470d75f4b8fb81b1abca4ee3b73f1ad8b22]
> adds a call to {{{log.err}}}. If that call to {{{log.err}}} is getting
> called, then that would cause the tests to fail in this way.

New description:

 Our buildbot shows that when this batch of patches went in:

 [f77ec470d75f4b8fb81b1abca4ee3b73f1ad8b22],
 [8e31d66cd0b0821ccaa2c7c259e7d6f262ad4738],
 [6a445d73bc5253ec4ae0dec70af02e33bc869cf6],
 [d85a75d7f689cb55ecddb319dc2057f38e4db87a]

 Then the FreeBSD and Slackware builders went from green to red. See this
 historical waterfall view:

 [//buildbot-tahoe-
 lafs/waterfall?builder=Markus+slackware64+current&builder=Randy+FreeBSD-
 amd64&reload=none&last_time=1372000000 https://tahoe-lafs.org/buildbot-
 tahoe-lafs/waterfall?builder=Markus+slackware64+current&builder=Randy
 +FreeBSD-amd64&reload=none&last_time=1372000000]

 Out of those four patches, I don't believe that
 [d85a75d7f689cb55ecddb319dc2057f38e4db87a] is relevant, but the other
 three could be. Especially note that the error message on the FreeBSD and
 Slackware builders is "twisted.trial.unittest.!FailTest: Errors snooped,
 terminating early", and that [f77ec470d75f4b8fb81b1abca4ee3b73f1ad8b22]
 adds a call to {{{log.err}}}. If that call to {{{log.err}}} is getting
 called, then that would cause the tests to fail in this way.

--

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2023#comment:1>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage