[tahoe-lafs-trac-stream] [tahoe-lafs] #1807: cleanup: HUMAN_RE regexes in uri.py are never used

tahoe-lafs trac at tahoe-lafs.org
Fri Jun 7 00:01:30 UTC 2013


#1807: cleanup: HUMAN_RE regexes in uri.py are never used
----------------------------+----------------------------------
     Reporter:  davidsarah  |      Owner:  daira
         Type:  defect      |     Status:  new
     Priority:  minor       |  Milestone:  1.11.0
    Component:  code        |    Version:  1.9.2
   Resolution:              |   Keywords:  cleanup url reviewed
Launchpad Bug:              |
----------------------------+----------------------------------
Changes (by zooko):

 * keywords:  cleanup url review-needed => cleanup url reviewed
 * owner:  warner => daira


Old description:

> From [source:src/allmydata/uri.py]:
> {{{
> # "human-encoded" URIs are allowed to come with a leading
> # 'http://127.0.0.1:(8123|3456)/uri/' that will be ignored.
> # Note that nothing in the Tahoe code currently uses the human encoding.
> }}}
>
> We should remove the dead code related to "human encoding" and instead
> make the normal parsing of URIs more tolerant: see #942, #884, and #885.

New description:

 From [source:src/allmydata/uri.py]:
 {{{
 # "human-encoded" URIs are allowed to come with a leading
 # 'http://127.0.0.1:(8123|3456)/uri/' that will be ignored.
 # Note that nothing in the Tahoe code currently uses the human encoding.
 }}}

 We should remove the dead code related to "human encoding" and instead
 make the normal parsing of URIs more tolerant: see #942, #884, and #885.

--

Comment:

 Okay, I agree! I scanned this patch and it looks good because it is all
 code-removal.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1807#comment:4>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list