[tahoe-lafs-trac-stream] [tahoe-lafs] #1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS

[tahoe-lafs]

#1847: Ugly shadowing of Client.DEFAULT_ENCODING_PARAMETERS
-------------------------------+------------------------
     Reporter:  davidsarah     |      Owner:  davidsarah
         Type:  defect         |     Status:  assigned
     Priority:  minor          |  Milestone:  1.11.0
    Component:  code-encoding  |    Version:  1.9.2
   Resolution:                 |   Keywords:  cleanup
Launchpad Bug:                 |
-------------------------------+------------------------

Old description:

> {{{Client}}} in [source:git/src/allmydata/client.py] has a class
> attribute called {{{DEFAULT_ENCODING_PARAMETERS}}}, and an instance
> attribute also called {{{DEFAULT_ENCODING_PARAMETERS}}} that shadows it.
> This is ugly and confusing.
>
> The linked pull request changes the name of the latter to
> {{{_encoding_parameters}}}.

New description:

 {{{Client}}} in [source:git/src/allmydata/client.py] has a class attribute
 called {{{DEFAULT_ENCODING_PARAMETERS}}}, and an instance attribute also
 called {{{DEFAULT_ENCODING_PARAMETERS}}} that shadows it. This is ugly and
 confusing.

 The linked pull request changes the name of the latter to
 {{{_encoding_parameters}}}.

--

Comment (by daira):

 Replying to [comment:3 zooko]:
 > Could this be related to #1830?

 No, see [ticket:1830#comment:5].

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1847#comment:4>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage