[tahoe-lafs-trac-stream] [tahoe-lafs] #1921: leasedb: NonExistentShareError: can't find [share] in `shares` table

[tahoe-lafs]

#1921: leasedb: NonExistentShareError: can't find [share] in `shares` table
------------------------------+----------------------------------------
     Reporter:  davidsarah    |      Owner:  davidsarah
         Type:  defect        |     Status:  new
     Priority:  major         |  Milestone:  soon
    Component:  code-storage  |    Version:  1.9.2
   Resolution:                |   Keywords:  leasedb accounting-crawler
Launchpad Bug:                |
------------------------------+----------------------------------------
Changes (by davidsarah):

 * keywords:  leasedb openstack cloud-backend crawlers => leasedb
     accounting-crawler


Comment:

 I believe this was fixed in commits 4cd54e36 ("leasedb/accounting crawler:
 only treat stable shares as disappeared or unleased") and 9ebc0e8b
 ("!OpenStack: fix a type error introduced by the fix to #1921") on the
 1909-cloud-openstack branch. Note that this is ''not'' on the 1818-leasedb
 branch, and in general I need to review all patches on 1909-cloud-
 openstack to see whether they are applicable to 1818-leasedb. I have just
 noted this on #1818.

 The problem was indeed not specific to !OpenStack (or the cloud backend).
 The leasedb design doc had the correct design, which was for the
 accounting crawler to treat shares in states other than STABLE as leased,
 but that requirement had been missed in the implementation. That reminds
 me that we need better tests for edge cases in the accounting crawler.

 I'll leave this ticket open until the fix is on the 1818-leasedb branch.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1921#comment:4>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage