[tahoe-lafs-trac-stream] [tahoe-lafs] #1926: Failed to load application: cannot import name IFinishableConsumer

[tahoe-lafs]

#1926: Failed to load application: cannot import name IFinishableConsumer
------------------------------------------------+--------------------------
 Reporter:  bsd                                 |          Owner:
     Type:  defect                              |         Status:  new
 Priority:  normal                              |      Milestone:
Component:  code-frontend                       |  undecided
 Keywords:  sftp, twisted, ifinishableconsumer  |        Version:  1.9.2
                                                |  Launchpad Bug:
------------------------------------------------+--------------------------
 The following error occurs when running `tahoe` using the latest Twisted
 (12.3.0), with SFTP frontend enabled

 {{{
 Unhandled Error
 Traceback (most recent call last):
   File "/usr/local/lib/python2.7/site-
 packages/twisted/application/app.py", line 652, in run
     runApp(config)
   File "/usr/local/lib/python2.7/site-packages/twisted/scripts/twistd.py",
 line 23, in runApp
     _SomeApplicationRunner(config).run()
   File "/usr/local/lib/python2.7/site-
 packages/twisted/application/app.py", line 386, in run
     self.application = self.createOrGetApplication()
   File "/usr/local/lib/python2.7/site-
 packages/twisted/application/app.py", line 451, in createOrGetApplication
     application = getApplication(self.config, passphrase)
 --- <exception caught here> ---
   File "/usr/local/lib/python2.7/site-
 packages/twisted/application/app.py", line 462, in getApplication
     application = service.loadApplication(filename, style, passphrase)
   File "/usr/local/lib/python2.7/site-
 packages/twisted/application/service.py", line 405, in loadApplication
     application = sob.loadValueFromFile(filename, 'application',
 passphrase)
   File "/usr/local/lib/python2.7/site-packages/twisted/persisted/sob.py",
 line 210, in loadValueFromFile
     exec fileObj in d, d
   File "tahoe-client.tac", line 10, in <module>
     c = client.Client()
   File "/usr/local/lib/python2.7/site-packages/allmydata/client.py", line
 155, in __init__
     self.init_sftp_server()
   File "/usr/local/lib/python2.7/site-packages/allmydata/client.py", line
 436, in init_sftp_server
     from allmydata.frontends import sftpd
   File "/usr/local/lib/python2.7/site-
 packages/allmydata/frontends/sftpd.py", line 25, in <module>
     from twisted.internet.interfaces import IFinishableConsumer
 exceptions.ImportError: cannot import name IFinishableConsumer

 Failed to load application: cannot import name IFinishableConsumer
 }}}

 Replacing all references to IFinishableConsumer with IConsumer in
 allmydata/frontends/sftpd.py resolves the issue (at least cosmetically, no
 errors on startup). Probably would be a good idea to review the changes
 between the two modules for the long run.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1926>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage