[tahoe-lafs-trac-stream] [tahoe-lafs] #1960: spurious warnings that look a little like errors when building/installing 1.10
tahoe-lafs
trac at tahoe-lafs.org
Wed May 15 16:13:44 UTC 2013
#1960: spurious warnings that look a little like errors when building/installing
1.10
---------------------------+----------------------------------------------
Reporter: daira | Owner: daira
Type: defect | Status: closed
Priority: minor | Milestone: 1.11.0
Component: packaging | Version: 1.10.0
Resolution: fixed | Keywords: warning build install setuptools
Launchpad Bug: |
---------------------------+----------------------------------------------
Comment (by zooko):
Replying to [comment:7 Daira Hopwood <david-sarah@…>]:
> In [changeset:"2fa832b060ac8c4ceadb94d74d0ac5e0586e432c/trunk"]:
> {{{
> #!CommitTicketReference repository="trunk"
revision="2fa832b060ac8c4ceadb94d74d0ac5e0586e432c"
> Add dummy __init__.py files for directories containing data. fixes #1960
>
> Signed-off-by: Daira Hopwood <david-sarah at jacaranda.org>
> }}}
I don't agree with this patch. I think it may cause other problems. Also,
I think it is masking a bug which we might benefit by fixing instead of
masking. Also, don't we usually require a sign-off from a reviewer other
than the author before committing patches to trunk?
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1960#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list