[tahoe-lafs-trac-stream] [tahoe-lafs] #1960: spurious warnings that look a little like errors when building/installing 1.10

[tahoe-lafs]

#1960: spurious warnings that look a little like errors when building/installing
1.10
---------------------------+----------------------------------------------
     Reporter:  daira      |      Owner:  daira
         Type:  defect     |     Status:  closed
     Priority:  minor      |  Milestone:  1.11.0
    Component:  packaging  |    Version:  1.10.0
   Resolution:  fixed      |   Keywords:  warning build install setuptools
Launchpad Bug:             |
---------------------------+----------------------------------------------

Comment (by daira):

 You're right that I should have waited for review before committing to
 trunk, sorry.

 ''Both'' the entry in "packages" and the entry in "package_data" are
 necessary. I just tested removing the former, and that does not install
 the files correctly. That informs my conclusion that it's a setuptools
 bug. (Note that setuptools certainly has enough information to see that
 there are no {{{.py[co]}}} files in the directory, and so the absence of a
 {{{__init__.py}}} file is harmless.)

 > Next weirdness: why is src/allmydata/web/static/css included in
 "packages" but src/allmydata/web/static/img isn't?

 I don't know why it appeared to work for me before without
 {{{allmydata.web.static.img}}} in "packages". In the testing I did just
 now, it doesn't copy the contents of the
 {{{src/allmydata/web/static/img/}}} directory without that when doing a
 system install. (So, another patch will be necessary to add it.)

 Note that we don't open data files directly as files; we open them using
 the {{{pkg_resources}}} module, which in principle should be able to read
 from zip files (but this is only relevant for bb-freeze and similar I
 think, because of the {{{zip_safe=False}}} flag).

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1960#comment:11>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage