[tahoe-lafs-trac-stream] [tahoe-lafs] #1893: don't do lease-renewal automatically

[tahoe-lafs]

#1893: don't do lease-renewal automatically
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:
         Type:           |     Status:  new
  enhancement            |  Milestone:  undecided
     Priority:  normal   |    Version:  1.9.2
    Component:  code-    |   Keywords:  leases garbage-collection
  storage                |  accounting design-review-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Old description:

> Currently lease-renewal happens when you explicitly tell your client to
> create a file or to renew leases, and also on some other occasions. I
> ''think'' that the "other occasions" are only when you update a mutable
> file, but I'm not sure. I don't think this is appropriate because in the
> future you might want to update a file without thereby agreeing to pay
> for the file's preservation.
>
> To close this ticket:
>
> 1. Read the source code and write down on this ticket all the ways that
> leases can get added or renewed.
> 2. Write a patch that removes the lease renewal from all cases except for
> when the client is either creating a file or sending an "Add or Renew
> Lease" request.
> 3. Of course, unit tests of step 2 are required!
>
> Brian: please let us know your opinion of this.

New description:

 Currently lease-renewal happens when you explicitly tell your client to
 create a file or to renew leases, and also on some other occasions. I
 ''think'' that the "other occasions" are only when you update a mutable
 file, but I'm not sure. I don't think this is appropriate because in the
 future you might want to update a file without thereby agreeing to pay for
 the file's preservation.

 To close this ticket:

 1. Read the source code and write down on this ticket all the ways that
 leases can get added or renewed.
 2. Write a patch that removes the lease renewal from all cases except for
 when the client is either creating a file or sending an "Add or Renew
 Lease" request.
 3. Of course, unit tests of step 2 are required!

 Brian: please let us know your opinion of this.

--

Comment (by daira):

 Isn't the fact that you're modifying a file a pretty strong heuristic
 indication that you want to keep it?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1893#comment:1>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage