[tahoe-lafs-trac-stream] [tahoe-lafs] #1641: fix regressions in convergent uncoordinated write detection

[tahoe-lafs]

#1641: fix regressions in convergent uncoordinated write detection
------------------------------+--------------------------------------
     Reporter:  kevan         |      Owner:  kevan
         Type:  defect        |     Status:  assigned
     Priority:  major         |  Milestone:  1.12.0
    Component:  code-mutable  |    Version:  1.9.0
   Resolution:                |   Keywords:  upload mutable mdmf sdmf
Launchpad Bug:                |
------------------------------+--------------------------------------

Comment (by daira):

 Replying to [ticket:1641 kevan]:
 > [...] Only {{{MDMFSlotWriteProxy}}} returns the checkstring associated
 with the current version of the mutable file, which is necessary in order
 for the #546 check to behave the same as in the pre-1.9 publisher. The fix
 for this issue is to change {{{SDMFSlotWriteProxy}}} to return the same
 checkstring as {{{MDMFSlotWriteProxy}}}.
 >
 > The practical impact of the first regression is that SDMF publish
 operations are less able to figure out when they need to abort a publish
 and try again after another map update. [...]

 We decided to remove the code that tries again (ticket:1670#comment:46),
 but {{{SDMFSlotWriteProxy}}} should probably be changed to use the same
 checkstring anyway, just for consistency and simplicity.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1641#comment:17>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage