[tahoe-lafs-trac-stream] [tahoe-lafs] #961: init scripts included in the apt-get install for tahoe-lafs on Debian/Ubuntu derivatives

[tahoe-lafs]

#961: init scripts included in the apt-get install for tahoe-lafs on
Debian/Ubuntu derivatives
-------------------------------------+-------------------------------------
     Reporter:  stott                |      Owner:  zooko
         Type:  enhancement          |     Status:  closed
     Priority:  normal               |  Milestone:  1.11.0
    Component:  packaging            |    Version:  1.5.0
   Resolution:  somebody else's      |   Keywords:  init security docs
  problem                            |  reviewed debian ubuntu
Launchpad Bug:                       |
-------------------------------------+-------------------------------------

Comment (by zooko):

 Okay, I just reviewed
 http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/tahoe-
 lafs.init;h=13b505fb4b2d4be959e3df7edef02a369a48fc7c;hb=8428876521454b5fd2b0719048caf909c0ab68ee
 . Here are my comments.

 Thank you for working on this patch! I'm excited about making Tahoe-LAFS
 be a more first-class citizen of the Debian universe. A lot of good can
 come of this. Thank you for your contribution.

 I don't understand why {{{/etc/init.d/tahoe-lafs restart}}} does {{{tahoe
 stop ; sleep 1 ; tahoe start}}} and {{{/etc/init.d/tahoe-lafs force-
 reload}}} does {{{tahoe restart}}}. I think both of those should do
 {{{tahoe restart}}}.

 I think {{{/etc/init.d/tahoe-lafs stop}}} should do {{{tahoe stop}}}
 instead of {{{kill `cat twistd.pid`}}}. That's because {{{tahoe stop}}}
 has a couple of features such as warning the user if the daemon doesn't
 stop after SIGKILL. See
 [source:trunk/src/allmydata/scripts/startstop_node.py?annotate=blame&rev=3ee950f09ed8b7f6cc72a98c26eefe9e02c11d85#L78
 the code here].

 Other than those two things, I didn't see anything strange or
 objectionable in this patch. Thanks again!

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/961#comment:35>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage