[tahoe-lafs-trac-stream] [tahoe-lafs] #1382: immutable peer selection refactoring and enhancements

[tahoe-lafs]

#1382: immutable peer selection refactoring and enhancements
-------------------------+-------------------------------------------------
     Reporter:  kevan    |      Owner:  markberger
         Type:           |     Status:  new
  enhancement            |  Milestone:  1.11.0
     Priority:  major    |    Version:  1.8.2
    Component:  code-    |   Keywords:  review-needed servers-of-happiness
  peerselection          |  blocks-release
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by markberger):

 During dev chat today (September 11th, 2013), Zooko and I talked about
 some modifications to `happiness_upload.py` that would make it easier to
 understand.

 * Add notes about when to use `_server_flow_graph` and when to use
 `_flow_network`.
 * Explain the graph data structure we use to represent a flow network.
 * Either summarize why we use flow networks to find the maximum spanning,
 or link to a good source instead of just referring to Introduction to
 Algorithms.
 * Combine `index_peers` and `index_shares` into one function.
 * Rename `peerids` and `shareids` to something else which makes it clear
 that they are indices used by the flow network.
 * Remove the repeated pattern in `generate_mappings` to its own function
 for clarity. That way reindexing can occur in the function and not
 distract the reader from what is occurring.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1382#comment:45>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage