[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2352: dead code/bug in error-handling in mutable.layout.MDMFSlotWriteProxy._write

[Tahoe-LAFS]

#2352: dead code/bug in error-handling in mutable.layout.MDMFSlotWriteProxy._write
---------------------+---------------------------
 Reporter:  zooko    |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  1.10.0
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 While investigating #2342, Brian and I noticed that
 [source:trunk/src/allmydata/mutable/layout.py?annotate=blame&rev=d8c536847b1ea577f9ac5b6aa98c7ce5d1961c8c#L1168
 this code] appears to be buggy. It is calling `addCallback()`, and then
 the callback function is checking if the arg is a `Failure`, but
 `Failure`'s would never get sent to a callback function, only to an
 errback function, which is not handled (here).

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2352>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage