[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2353: make sure all file objects get explicitly closed

[Tahoe-LAFS]

#2353: make sure all file objects get explicitly closed
---------------------+---------------------------
 Reporter:  zooko    |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  1.10.0
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 Find all places that we open a file and make sure that we explicitly close
 that file object instead of relying on garbage-collection/reference-
 counting to close the file as a side-effect of freeing up the object.

 Here's an example of a buggy bit of code where we call `close()` on only
 one branch of an if:
 [source:trunk/src/allmydata/storage/mutable.py?annotate=blame&rev=d5651a0d0eebdc144db53425ee461e186319e5fd#L336
 storage/mutable.py line 336].

 See also #1437.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2353>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage