[tahoe-lafs-trac-stream] [tahoe-lafs] #2128: comments in tahoe.cfg cause introducers to appear down

[tahoe-lafs]

#2128: comments in tahoe.cfg cause introducers to appear down
-------------------------+--------------------------------------------
     Reporter:  amiller  |      Owner:  daira
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  undecided
    Component:  unknown  |    Version:  1.10.0
   Resolution:           |   Keywords:  review-needed usability config
Launchpad Bug:           |
-------------------------+--------------------------------------------

Comment (by amiller):

 I was distracted previously by the config parser, but it's actually the
 [https://twistedmatrix.com/trac/browser/tags/releases/twisted-13.2.0/twisted/internet/endpoints.py#L1257
 twisted endpoint parser] that matters. My approach
 [https://github.com/amiller/tahoe-
 lafs/commit/c88d4ea1055dce1e767e82589acbb4697ae9de0f in this latest patch]
 is to emulate this function except for rejecting unescaped # - the case of
 {{{r"test\\#test"}}} is correctly rejected, for example.

 Now to address comment:8, about applying this check uniformly to every
 endpoint string in the config... it appears that every furl in the config
 has a label of the form "blah.furl". Should I rely on this and put the
 check in {{{node.get_config}}}?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2128#comment:19>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage