[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1927: cloud backend spams twistd.log with two entries for each HTTP connection

[Tahoe-LAFS]

#1927: cloud backend spams twistd.log with two entries for each HTTP connection
--------------------------+------------------------------------------------
     Reporter:            |      Owner:  daira
  davidsarah              |     Status:  assigned
         Type:  defect    |  Milestone:  soon
     Priority:  normal    |    Version:  cloud-branch
    Component:  code-     |   Keywords:  twisted http logging cloud-backend
  storage                 |
   Resolution:            |
Launchpad Bug:            |
--------------------------+------------------------------------------------

Comment (by daira):

 This happened to a !LeastAuthority customer server. The culprit appears to
 be the logging when the `noisy` attribute is set on an
 `HTTPClientFactory`, for example
 [https://github.com/twisted/twisted/blob/63be1f698a60d572fc6436cbc0af9e0fcff9713e/twisted/internet/protocol.py#L70
 here in twisted/internet/protocol.py].

 I think (but have no way to test from where I am now) that it can be fixed
 by changing [https://github.com/tahoe-lafs/tahoe-lafs/blob/2237-cloud-
 backend-s4/src/allmydata/storage/backends/cloud/s3/s3_container.py#L55
 this line in s3_container.py] to:
 {{{
     query = Query(*args, **kwargs)
     if hasattr(query.factory, 'noisy'):
         query.factory.noisy = False
     return query
 }}}

 Note that this only changes the S3 container; other cloud containers also
 use `HTTPClientFactory` and will need changing.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1927#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage