[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2209: Missing `allmydata/web/static/img` subdirectory when installed from `pip`.

[Tahoe-LAFS]

#2209: Missing `allmydata/web/static/img` subdirectory when installed from `pip`.
-------------------------------+---------------------------
 Reporter:  nejucomo           |          Owner:  daira
     Type:  defect             |         Status:  new
 Priority:  normal             |      Milestone:  undecided
Component:  unknown            |        Version:  1.10.0
 Keywords:  packaging pip web  |  Launchpad Bug:
-------------------------------+---------------------------
 **Synopsis:**

 The front page [https://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/src/allmydata/web/welcome.xhtml welcome.xhtml] has
 [https://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/src/allmydata/web/welcome.xhtml#L23 an image link] for
 `/img/logo.png` which does not exist in a `pip` installed tahoe.  In fact,
 the entire `allmydata/web/static/img` subdirectory is absent:

 {{{
 $ cd $VIRTUAL_ENV
 $ find . -name '*.png'
 ./lib/python2.7/site-packages/allmydata/web/static/icon.png
 $ ls ./lib/python2.7/site-packages/allmydata/web/static/
 css  d3-2.4.6.min.js  d3-2.4.6.time.min.js  download_status_timeline.js
 icon.png  jquery-1.6.1.min.js  tahoe.css
 $ ./bin/tahoe --version
 allmydata-tahoe: 1.10.0
 foolscap: 0.6.4
 pycryptopp: 0.6.0.1206569328141510525648634803928199668821045408958
 zfec: 1.4.24
 Twisted: 13.2.0
 Nevow: 0.10.0
 zope.interface: unknown
 python: 2.7.5+
 platform: Linux-debian_jessie/sid-x86_64-64bit_ELF
 pyOpenSSL: 0.14
 simplejson: 3.3.3
 pycrypto: 2.6.1
 pyasn1: 0.1.7
 mock: 1.0.1
 setuptools: 0.9.8

 Warning: dependency 'cryptography' (version '0.3') found by pkg_resources
 not found by import.
 Warning: dependency 'six' (version '1.6.1') found by pkg_resources not
 found by import.
 Warning: dependency 'cffi' (version '0.8.2') found by pkg_resources not
 found by import.
 Warning: dependency 'pycparser' (version '2.10') found by pkg_resources
 not found by import.

 For debugging purposes, the PYTHONPATH was
   '/home/n/lib/python:/usr/lib/pyshared/python2.7/'
 install_requires was
   ['setuptools >= 0.6c6', 'zfec >= 1.1.0', 'simplejson >= 1.4',
 'zope.interface == 3.6.0, == 3.6.1, == 3.6.2, >= 3.6.5', 'Twisted >=
 11.0.0', 'foolscap >= 0.6.3', 'pyOpenSSL', 'Nevow >= 0.6.]
 sys.path after importing pkg_resources was
   /home/n/virtualenvs/lafs-wapi-dev/bin:
   /home/n/lib/python:
   /usr/lib/pyshared/python2.7:
   /home/n/virtualenvs/lafs-wapi-dev/lib/python2.7:
   /home/n/virtualenvs/lafs-wapi-dev/lib/python2.7/plat-x86_64-linux-gnu:
   /home/n/virtualenvs/lafs-wapi-dev/lib/python2.7/lib-tk:
   /home/n/virtualenvs/lafs-wapi-dev/lib/python2.7/lib-old:
   /home/n/virtualenvs/lafs-wapi-dev/lib/python2.7/lib-dynload:
   /usr/lib/python2.7:
   /usr/lib/python2.7/plat-x86_64-linux-gnu:
   /usr/lib/python2.7/lib-tk:
   /home/n/virtualenvs/lafs-wapi-dev/local/lib/python2.7/site-packages
 }}}

 **Details:**

 The image link was added in [https://tahoe-lafs.org/trac/tahoe-
 lafs/changeset/709be93a29e20026e61a436dac3fa1c160e9cef2/trunk changeset
 709be93a29e20026e61a436dac3fa1c160e9cef2], which also contains the image.

 I checked to see if this was a case of build misconfiguration, and it
 appears that the image should be included in the [https://tahoe-
 lafs.org/trac/tahoe-
 lafs/browser/trunk/MANIFEST.in?rev=709be93a29e20026e61a436dac3fa1c160e9cef2
 MANIFEST.in].

 I also verified that an `sdist` tarball generated from `master` has the
 file:

 {{{
 $ git checkout master
 Already on 'master'
 Your branch is up-to-date with 'origin/master'.
 $ git rev-parse HEAD
 0ef593947755a8b81edc73d033219724268faf80
 $ rm -rf ./dist/
 $ python ./setup.py sdist | grep logo
 warning: no previously-included files matching '*~' found anywhere in
 distribution
 hard linking src/allmydata/web/static/img/logo.png -> allmydata-
 tahoe-1.10.0.post76/src/allmydata/web/static/img
 $ tar -tzf ./dist/allmydata-tahoe-1.10.0.post76.tar.gz | grep logo.png
 allmydata-tahoe-1.10.0.post76/src/allmydata/web/static/img/logo.png
 }}}

 At this point I am uncertain how the `pip` package `allmydata-tahoe` is
 generated.  It seems like a potential next step is to create a //packaging
 test// within the `buildbot` configuration to verify that this file is
 included in the `allmydata-tahoe` package distribution.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2209>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage