[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1836: use leasedb (not crawler) to figure out how many shares you have and how many bytes

[Tahoe-LAFS]

#1836: use leasedb (not crawler) to figure out how many shares you have and how
many bytes
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  markberger
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  1.12.0
    Component:  code-    |    Version:  1.9.2
  storage                |   Keywords:  leases garbage-collection test-
   Resolution:           |  needed accounting
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by remyroy):

 * keywords:  leases garbage-collection review-needed accounting => leases
     garbage-collection test-needed accounting
 * owner:  remyroy => markberger
 * status:  assigned => new


Comment:

 Review of https://github.com/markberger/tahoe-lafs/tree/1836-use-leasedb-
 for-share-count :

 Good job with this change. There are a few small things that I found.

 I could not run the full test suite. It might be because this branch was
 made on a somewhat old version of tahoe-lafs. There are a bunch of
 "exceptions.ImportError: cannot import name HTTPConnectionPool" in the
 tests. If you could merge your branch with the latest trunk version, it
 might solve this.

 In src/allmydata/web/storage.py, it seems like there are still a few
 remaining BucketCountingCrawler stuff there are still left. For instance,
 in StorageStatus.render_JSON, you are still returning bucket-counter even
 though it returns None for it. Is this because the UI expects it? If this
 is the case, the UI might need to be changed as well as the backend.
 Another one is StorageStatus.render_count_crawler_status . Is this still
 needed for something if the crawler was removed?

 Reassigning to markberger to fix those issues.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1836#comment:22>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage