[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1589: S3 backend: when a txaws operation gets an error response, include the full request URI and response body in the exception message, and maybe trigger an incident

[Tahoe-LAFS]

#1589: S3 backend: when a txaws operation gets an error response, include the full
request URI and response body in the exception message, and maybe trigger
an incident
-----------------------------+---------------------------------------------
     Reporter:  davidsarah   |      Owner:  davidsarah
         Type:  defect       |     Status:  closed
     Priority:  major        |  Milestone:  1.12.0
    Component:  code-        |    Version:  1.9.0-s3branch
  storage                    |   Keywords:  error s3-backend txaws reviewed
   Resolution:  fixed        |
Launchpad Bug:               |
-----------------------------+---------------------------------------------
Changes (by daira):

 * milestone:  soon => 1.12.0


Old description:

> The exception message shouldn't include secrets (AWS secret key, user
> token or product token), or data, but the request URI and the body of
> error responses are short enough to include in full. In particular the
> response code, which txaws currently drops, would be useful. We don't
> send any caps in S3 requests.
>
> It would also be useful to trigger an incident for errors that we don't
> understand or haven't seen before (probably based on the HTTP response
> code).

New description:

 The exception message shouldn't include secrets (AWS secret key, user
 token or product token), or data, but the request URI and the body of
 error responses are short enough to include in full. In particular the
 response code, which txaws currently drops, would be useful. We don't send
 any caps in S3 requests.

 It would also be useful to trigger an incident for errors that we don't
 understand or haven't seen before (probably based on the HTTP response
 code).

--

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1589#comment:13>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage