[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1634: TypeError due to "size" being None in pyfilesystem+dokan

Fri Oct 10 16:03:46 UTC 2014

#1634: TypeError due to "size" being None in pyfilesystem+dokan
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  Zancas
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.9.0
  frontend-web           |   Keywords:  pyfilesystem dokan error webapi
   Resolution:           |  docs mutable
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by zooko):

 * keywords:  pyfilesystem dokan error webapi docs mutable test-needed =>
     pyfilesystem dokan error webapi docs mutable

Comment:

 I reviewed this and found one bug:

 https://github.com/zancas/tahoe-
 lafs/commit/8a007e4a033c9512c7dfcf1bd66cf2fb9958532c#commitcomment-8116954

 Other comments:

 * https://github.com/zancas/tahoe-
 lafs/commit/bd473cdaca9c9da8b214d32f5bc6bd4ec25bd8a7#commitcomment-8117345
 * https://github.com/zancas/tahoe-
 lafs/commit/41749ce952bad93f84aa9fd3943bac3e8a6d35b5#commitcomment-8117422
 * https://github.com/zancas/tahoe-
 lafs/commit/41749ce952bad93f84aa9fd3943bac3e8a6d35b5#commitcomment-8117538
 * https://github.com/zancas/tahoe-
 lafs/commit/41749ce952bad93f84aa9fd3943bac3e8a6d35b5#commitcomment-8117560

 I really like the three-part approach of refactor, unit test, patch.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1634#comment:26>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage